Please make it possible to override the base command of the build container

aressem · March 27, 2024, 1:52pm

I would like to start the build container with a working systemd inside. This means having /sbin/init as PID 1. Currently there is no good way to do this as the container command is hardcoded here:

github.com

buildkite/agent-stack-k8s/blob/2bf25843d9aaa1cbf2b0b0bb6b742cb1187b5e1c/internal/controller/scheduler/scheduler.go#L248


      
          	if !skipCheckout {
          		systemContainerCount = 1
          	}
          
          	ttl := int32(w.cfg.JobTTL.Seconds())
          	kjob.Spec.TTLSecondsAfterFinished = &ttl
          
          	podSpec := &kjob.Spec.Template.Spec
          	for i, c := range podSpec.Containers {
          		command := strings.Join(append(c.Command, c.Args...), " ")
          		c.Command = []string{"/workspace/buildkite-agent"}
          		c.Args = []string{"bootstrap"}
          		c.ImagePullPolicy = corev1.PullAlways
          		c.Env = append(c.Env, env...)
          		c.Env = append(c.Env,
          			corev1.EnvVar{
          				Name:  "BUILDKITE_COMMAND",
          				Value: command,
          			},
          			corev1.EnvVar{
          				Name:  "BUILDKITE_AGENT_EXPERIMENT",

It would be nice to be able to override this command to be able to start /sbin/init and then the buildkite-agent with its arguments.

We could ofcourse hack this in to a container image derived from the official one, but would rather not

karen.sawrey · March 27, 2024, 4:00pm

Hello, @aressem and welcome to the Buildkite Community!

Thank you for pointing out this use case!
We recommend that for this change you open an issue directly on the Buildkite Agent Stack for Kubernetes repository.

Best!
Karen

aressem · March 27, 2024, 8:42pm

Thank you Karen. Created Make it possible to run init/systemd inside the build container · Issue #283 · buildkite/agent-stack-k8s · GitHub for this.

Cheers,
Arnstein

Topic		Replies	Views
Allow agent targeting overrides through UI & API before running pipelines Features Requests	5	777	August 18, 2020
User ID for build agent - how to specify that? General	3	961	September 19, 2019
Overwrite default environment variables (e.g., BUILDKITE_REPO) via pipeline upload General	2	2524	February 9, 2021
Should I Create A Second Agent For More Sensitive Jobs General	4	365	August 29, 2023
Start agent container on build General	3	586	May 11, 2020

Please make it possible to override the base command of the build container

Related topics