[BUG] Failed command steps are continuing

General
1

Per the buildkite documentation: Command Step | Buildkite Documentation

The shell command/s to run during this step. This can be a single line of commands, or a list of commands that must all pass. Also available as the alias commands.

The following pipeline works (and it shouldn’t).

steps:
  - commands:
    - false
    - echo "false (previous step) returned $?"
    - echo "Should not get here"

Screen Shot 2021-08-31 at 12.38.19
Screen Shot 2021-08-31 at 12.38.192462×706 99.6 KB

Did something change recently? I don’t remember it doing this, and it’s doing all sorts of weird things to our CI/CD?

Interestingly, the build fails if the last command errors:

steps:
  - commands:
    - false
    - echo "false (previous step) returned $?"
    - echo "Should not get here"
    - false

Screen Shot 2021-08-31 at 13.00.02
Screen Shot 2021-08-31 at 13.00.022282×790 136 KB

2

Hi @chomey,

Could you please send an email to support@buildkite.com with the link to the build so we can take a better look?

Thanks!

3

Sure, done.

4

Update for anyone else who comes across this.

Our .buildkite/hooks/command file was missing set -e. We weren’t seeing it in other builds because those repos had that set

1 Like
5

Thanks for your help @paula !

1 Like