I’m not sure of the requirements for outsiders to contribute changes to your plugins.
I switched from the cultureamp/aws-assume-role plugin to using your aws-assume-role-with-web-identity plugin and found it worked in most cases but was failing when combined with your artifacts plugin.
It is because both cultureamp/aws-assume-role and artifacts run as a pre-command hook, while aws-assume-role-with-web-identity runs as an environment hook, and so assumes the IAM role before the artifacts hook gets a chance to run.
I’ve raised the following pull-request that introduces a new optional hook parameter that if left unset or set to environment will run it as an environment hook just as the plugin does now, or if set to pre-command hook, runs as a pre-command hooks so that I can use it with the artifacts hook.
Is raising a pull-request enough to get the ball rolling? Or is there more I need to do?
I’ve seen no comments (positive or negative) on the pull request I have raised, and still no reviewers have been assigned. Are you sure the engineers are aware of it?
I’ve double checked and they are aware, it’s in their pipeline to review it. I’m not sure of any timeline for this to happen but we’ll add any updates to the pull request if there’s anything you need to know
