Contributing to aws-assume-role-with-web-identity plugin

I’m not sure of the requirements for outsiders to contribute changes to your plugins.

I switched from the cultureamp/aws-assume-role plugin to using your aws-assume-role-with-web-identity plugin and found it worked in most cases but was failing when combined with your artifacts plugin.
It is because both cultureamp/aws-assume-role and artifacts run as a pre-command hook, while aws-assume-role-with-web-identity runs as an environment hook, and so assumes the IAM role before the artifacts hook gets a chance to run.

I’ve raised the following pull-request that introduces a new optional hook parameter that if left unset or set to environment will run it as an environment hook just as the plugin does now, or if set to pre-command hook, runs as a pre-command hooks so that I can use it with the artifacts hook.

Is raising a pull-request enough to get the ball rolling? Or is there more I need to do?

Hey Jim :wave:

Welcome to the Buildkite community!

Thanks for proposing the changes via PR. It will be reviewed by our team and we can continue further conversation on the PR.

Cheers,
Priya!

1 Like

The PR itself has no reviewer or assignees set

But it did say buildkite-plugins/plugin-engineering was requested for review as a codeowner

I’m curious if anyone will actually see this PR if no one has ended up assigned to it?

Hey Jim :wave:

It is assigned to our plugin engineering team and currently on our board :)

We will take a look and continue discussion on the PR.

Cheers,
Priya

1 Like