We’re seeing cases where new builds are created for a commit on a PR when the PR is marked “ready for review”. However, our pipeline settings show that the “Build when pull requests become ready for review” option disabled.
1 Like
If we receive the event “Pull Request open”, we’ll trigger a build in that case. The extra option "Build when pull requests become ready for review” means that when you have the PR in Draft, and you change it to “Ready for Review” it will trigger another build for that event.
Can you send some build examples to support@buildkite.com where you didn’t expect to trigger a build? so we can have a better look 
Thanks!
Hi Paula, thanks for responding here! Here are two builds, even though the PR only ever had one commit. The second build was created when the PR was marked “ready for review”, even though our settings have “Build when pull requests become ready for review” disabled.
Thanks!
Build #25054 was a push commit and because you have “Build branches” enable, it triggered a build. Build #25056 was a “Pull Request open” event and that’s why it triggered a build. A couple of seconds later we received the “Ready for Review” event, and that one didn’t trigger a build.
Sometimes webhooks are not sent in the order they were actually created, especially when only seconds passed between them.
Aha! Mystery solved. Thank you Paula!
1 Like
This topic was automatically closed 30 days after the last reply. New replies are no longer allowed.