Running git diff --exit-code

General
1

Hi,
I’m building a step in my pipeline that checks if the developer has ran the formatting step or not.

In a nutshell, my logic involves running golines ./ --max-len=120 --write-output and checking for any files that were written using git diff --exit-code

However, I’m running into git error 129 which I’m unable to decipher.
Can you please help me out with this?

Step:

  - label: "NP | Check go formatting"
    key: "np-check-formatting"
    commands: |
      set -euo pipefail
      cd networkplanner
      
      echo --- Checking for formatting
      make format
      
      cd ..
      if ! git diff --exit-code; then
          echo "Go files were not formatted correctly. Please commit the changes after running make format."
          git diff  # Show the differences
          exit 1
      else
          echo "All Go files are formatted correctly."
      fi
    plugins:
      - docker#v5.9.0:
          image: "golang:1.22.1"
          volumes:
            # Necessary for docker-in-docker testcontainers
            - "/var/run/docker.sock:/var/run/docker.sock"
          network: "host"
          shell: ["/bin/bash", "-c"]
          environment:
            - GO_BIN_PATH=/go/bin

Link to pipeline → https://buildkite.com/equinix/ngo-engineering/builds/2398#01950142-6c7b-450e-b6d8-df8b5bbe3448

2

Hey! So to close the loop on this one. We had a conversation with the user and after some debugging and a couple of changes on their side, they are not getting git errors 129 anymore