This new favicon is terrible. It takes longer to cognitively process that it is a failing job because you have to look at a corner of the favicon. Worse, your default logo is green so you have to parse the difference between “normal green” and “good green” to figure out if a job is passing or not.
CircleCI has your preexisting behavior where the entire favicon changes color. I’m sympathetic that it’s easier for them because their default icon is black/gray so they can change green/yellow/red depending on status but that’s not really something a user of your software should have to care about. Buildkite is a tool and I don’t like that you chose branding consistency over its utility.
