Branch-name for pull requests

General
1

I’m using buildkite to build pull-requests but I’m confused about one behaviour I see: When I first submit a PR the request name is:

buildkite/[pipeline-slug]

but if it fails and I restart the build it appears as:

buildkite/[pipeline-slug]/pr

How do I get a consistent behaviour so I can properly set the branch requirements in github?

Example PR → Docs, Saleae stub-out, et-al by thirtytwobits · Pull Request #14 · thirtytwobits/nanaimo · GitHub
Pipeline (public) → https://buildkite.com/friends-of-scott/nanaimo-pr

Thanks.

2

Adding a screenshot since the other PR was already closed:

50%20PM
50%20PM1576×1104 142 KB

This is a real annoyance. I’d really link to know what I’m doing wrong. Thanks.

Also to correct my previous post: the behavior is that the initial PR using the /pr suffix but subsequent builds do not.

3

Hi @thirtytwobits! :wave:

You can make Buildkite always set the same commit statuses by going into your pipeline’s settings, into GitHub, and then changing the Separate statuses for pull requests checkbox:

image
image1700×478 71.3 KB

We added this for folks that do different steps for builds on push versus builds from pull requests.

You might also like to check the other settings in repository builds there. We use master in the Branch Filter Pattern so that master pushes and merges are always built and deployed but other branches are only built once they get turned into pull requests and have a full pull request context, for example.

Cheers,
Sam

4

But I want to use separate statuses for pull requests. It works as expected the first time but if I push an update to the pull request a second build is created that doesn’t use the /pr suffix. It seems like a bug? Perhaps your system doesn’t recognize that the update is part of the same pull request?

5

Ah, that does sound like a problem. Want to email the specifics of the pipeline and builds you’re wrestling with to support@buildkite.com so we can take a look?

6

I started an email thread with Eleanor Kiefel Haggerty via email over the weekend since I wasn’t sure if this post got lost in the noise. I’ll continue to follow up with her.

7

Sorry for the delay @thirtytwobits :frowning_face: Support is always the best option if there’s a specific issue that you need help with. :+1:

8

I’m experiencing the same issue. First PR build is called buildkite/maison-pr; second is called buildkite/maison-pr/pr. I will email support.

9

I’m still having this issue. Anyone find a fix yet?

10

Hi @thirtytwobits!

Hmm, we don’t have this as an active issue :thinking: Could you email support@buildkite.com with more details of the pipelines and builds where you are having this problem?

Sometimes happens that builds statuses are visible on the PR because they use different labels, as GitHub stores build status against a commit sha only. This means all statuses submitted for the commit are visible, regardless of whether they were intended to be linked with the PR.

Thanks!